[Bug 478694] Review Request: rfdump - RFID-Tags detector

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478694


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-05 00:30:17 EDT ---
+ OK
- Need work

Review:
+ package builds in mock (rawhide i386).
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1032469
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
9db8053b5e2268234f516daed2731db8  rfdump-1.6.tar.gz
- Source URL is not working and should be
http://www.rfdump.org/dl/rfdump-1.6.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package rfdump-1.6-1.fc11 =>
Provides: rfdump = 1.6-1.fc10 rfdump(x86-32) = 1.6-1.fc10
Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libcairo.so.2 libexpat.so.1
libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0
libgio-2.0.so.0 libglade-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0
libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0
libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libxml2.so.2 rtld(GNU_HASH)
+ Desktop file installed correctly.
+ GUI app.

Suggestions:
1) Change Source URL to
http://www.rfdump.org/dl/%{name}-%{version}.tar.gz

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.