[Bug 474535] Review Request: clamtk - Easy to use front-end for ClamAV

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474535





--- Comment #8 from Dan Horák <dan at danny.cz>  2009-01-05 02:51:41 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     2f6cd136e0975f980f32628d908d1686b49f948a  clamtk-4.08.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
BAD license field matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
BAD BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
N/A debuginfo package looks complete.
OK* rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
BAD no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK is a GUI app, desktop file is installed.


- the LICENSE file says this software is licensed "same as Perl", that means
the License tag should be "GPL+ or Artistic"
- I don't see a reason why should be "gettext" required for building, the
%build section is empty
- rpmlint complains about hardcoded "lib", but this is a noarch package. Why
can't be the content of ClamTk directory installed into regular Perl modules'
place?
- you should not specify Requires(pre,post): desktop-file-utils when a
scriptlet is present for updating the desktop database -
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
- the Gtk2 and other perl modules should not be included as manual "Requires",
they are found automagically during the package building process
- no need to run "update-mime-database" in the scriptlets because no file is
dropped into %{datadir}/mime/... -
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.