[Bug 478674] Review Request: pp3 - Creation of sky charts in Postscript or PDF format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478674


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Lubomir Rintel <lkundrak at v3.sk>  2009-01-05 10:11:37 EDT ---
Much better!

1.) Soooo... you actually strip the binary upon installation:

        install -s pp3 $(ROOT)$(DESTDIR)

Please patch the -s away from that, so that debuginfo is not empty.

2.) You get a lot of these:

pp3.i386: W: file-not-utf8 /usr/share/info/leo1.png.gz
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

Please %exclude %{_infodir}/*.png* files

You can fix those upon commit.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.