[Bug 475144] Review Request: metalink - CLI Metalink generation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475144





--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-06 12:50:30 EDT ---
Well, some notes for 0.3.6-1:

* SourceURL
  - For sourceforge hosted tarball, please follow
    https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

* BuildRequires
  - "BuildRequires: gcc-c++ libstdc++-devel make" are redundant.
  - Is "help2man" really used when rebuilding this srpm?

* Timestamps
  - It is preferred to use
-----------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
-----------------------------------------------------------
    to keep timestamps on installed files.
    This method usually works for Makefiles based on recent
    autotools

* %defattr
  - Now we recommend %defattr(-,root,root,-)

* rpmlint issue
-----------------------------------------------------------
metalink.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1)
metalink.src: E: description-line-too-long a .metalink is an XML file that
describes a download, and includes mirrors and checksum information.
metalink.i386: W: spurious-executable-perm
/usr/share/doc/metalink-0.3.6/example/gen.sh
-----------------------------------------------------------
  - Please use spaces or tabs for indention, not both, for
    cosmetic issue.
  - Cut one line in two lines or so when it exceeds 79 characters.
  - Usually I suggest that all files marked as %doc should have
    0644 permission.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.