[Bug 459946] Review Request: pfscalibration - Scripts and programs for photometric calibration

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 7 09:58:51 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459946


Lucian Langa <cooly at gnome.eu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

Bug 459946 depends on bug 459944, which changed state.

Bug 459944 Summary: Review Request: pfstools - Programs for handling high-dynamic range images
https://bugzilla.redhat.com/show_bug.cgi?id=459944

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE



--- Comment #13 from Lucian Langa <cooly at gnome.eu.org>  2009-01-07 04:58:49 EDT ---
(In reply to comment #12)

> The flags provided are used.  There are just some additional flags passed. 
> Nothing got broken.
- Fedora specific compilation flags are not honoured. (rpm --eval %optflags)
Overriding or filtering parts of these flags is permitted only if there's a
good reason to do so.

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags


> Anyway, I have changed it slightly, similar to the way it is done in the pfstmo
> package.  I'm now replacing the -O2 option only with some additional options
> for higher optimization.  These higher optimizations are appropriate in this
> case.
- -O3 flag is generally forbidden (it makes debugging difficult).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list