[Bug 470914] Review Request: slv2 - An LV2 host library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470914


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Michael Schwendt <bugs.michael at gmx.net>  2009-01-08 07:37:32 EDT ---
> perl in %prep section.

Works with this release, but is fragile. It bears the risk of replacing
/usr/lib64 with /usr/lib6464 in future upgrades, for example. You could avoid
that by handling the slash after /usr/lib and /usr/local appropriately in the
match and replacement (if not using a more complex sed/perl expr).

Typically, a patch (and optionally a guard in %prep) is safer.



* slv2-devel is missing

  Requires: lv2core-devel redland-devel

for include statements in lv2_ui.h and world.h
That's easy to add in pkg cvs, though.


* APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.