[Bug 472683] Review Request: jpcap - Packet capturing library for Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472683


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-08 13:29:34 EDT ---
For 0.7-4:

* SourceURL
  - I recommend to use %{name} and %{version}, especially
    %{version}. With this you probably won't have to change
    the source URL when version is updated:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* Tarball
  - By the way the tarball I could download from the Source URL
    differs from what in your srpm:
--------------------------------------------------------------
716370 2007-06-12 03:27 downloaded/jpcap-0.7.tar.gz
715154 2009-01-06 15:51 jpcap-0.7-4.fc10.src/jpcap-0.7.tar.gz
--------------------------------------------------------------
    (If there is CRLF line terminators difference, please don't
     fix this in advance but fix CRLF terminators at %prep)

* Requires
  - "Requires: libpcap" is not needed.
    rpmbuild detects libraries related dependencies automatically
    (in this case libpcap.so.0.9 on F-11) and adds the dependencies
    to binary rpms.

* JAVA_HOME
  - There is %java_home macro and you can use it
  - By the way you may want to use %ant macro instead
    (please try $ rpm --eval %ant)

* Build failure/optflags
  - Your srpm fails to build on x86_64:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1038602
    This is because C codes are not compiled with -fPIC.

    Also Fedora specific compilation flags are not correctly
    honored:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

    For this package
---------------------------------------------------------------
make %{?_smp_mflags} CC="gcc %{optflags} -fPIC"
---------------------------------------------------------------
    seems to work.

* Don't strip binaries
  - Please don't strip binaries. Debug information is required
    to create debuginfo rpm correctly (i.e. rpmbuild properly
    handles this: also please make sure that binaries are compiled
    with -g -- %{optflags} contains this)

* Directory ownership issue
  - The directory %{_libdir}/%{name} itself is not yet owned
    by this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.