[Bug 459535] Review Request: backup-manager - A command line backup tool for GNU/Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459535





--- Comment #15 from Aurelien Bompard <gauret at free.fr>  2009-01-10 13:43:53 EDT ---
> No you didn't.

Yes I did. You can choose not to believe me of course.

> The review guidelines state: "MUST: rpmlint must be run on every
> package. The output should be posted in the review." The output includes some
> warnings of which at least one needs to be fixed, but you did not post the
> output here.

Here's the output of rpmlint here :
backup-manager.noarch: W: incoherent-version-in-changelog 0.7.7-3
['0.7.7-3.fc10', '0.7.7-3.fc10']
Which is completely useless.

> The review guidelines also state: "MUST: The package must meet the Packaging
> Guidelines." and the packaging guidelines include: "When downloading sources,
> patches etc, consider using a client that preserves the upstream timestamps."

Note the "consider". Preserving the timestamp of the source tarball is a minor
detail.

> You did not check the timestamps, did you?

You should take the guidelines with a little more distance. Use your experience
and your judgment to know what's important and what's "nice to have" in this
very long list of guidelines.

It's nice however that you found out about the binary dependencies.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.