[Bug 459535] Review Request: backup-manager - A command line backup tool for GNU/Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459535





--- Comment #17 from Aurelien Bompard <gauret at free.fr>  2009-01-10 16:12:26 EDT ---
> The review guidlines include the packaging guidelines and at least the latter
> are not met.

That's not my point of view. I can't see _actual_ errors in your added remarks,
except the binary dependencies (which could cause the package not to work). But
finding those require to inspect the code, and the guidelines don't make that
mandatory. Maybe it should be added as a SHOULD item, only in the case of shell
scripts (where those are common) ?

> backup-manager.src: W: strange-permission backup-manager-0.7.7.tar.gz 0770
> backup-manager.src: W: strange-permission backup-manager.spec 0770
> backup-manager.src: W: strange-permission backup-manager.cron.daily 0770

I did run rpmlint on the src.rpm, and the "strange-permission" warning is also
not something I consider important: the source permissions will not be
preserved when the package is imported in CVS.

> Hint: You should also run rpmlint on the installed package, because some 
> errors are not detected otherwise.

Hey ! I never realized rpmlint could be run on installed packages ! Thanks a
lot for pointing this out !

> This is IMO also part of the review guidelines.

No, it's not required to inspect the source code of a package under review.

> P.S.: I know I am pedantic ;)

:) Look, I know you are trying to improve the quality of the packages in
Fedora, and I understand your point of view. However, Fedora, and fedora.us
before it, has already tried this route. And we ended up where we have to
actually cache as static HTML the list of packages awaiting review, because it
is so huge. And after the review, the packager is free to make all the mistakes
he wants... We have a big problem here, and this bug is not the place to
discuss it, but please understand that sometimes "the better is the enemy of
the good". We must not scare packagers away, or bore them to death (this bug
was submitted in august 2008). If my review looks perfectible to you, that's
because it is. Imperfect, but good enough IMO. That's my point of view, and I
can totally understand if you don't share it (and it's nice, we need people
like you too).

Please finish your review of backup-manager, and reassign the bug to you. And
thanks for helping out, sincerely.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.