[Bug 478504] Review Request: gget - Download Manager for the GNOME desktop.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478504





--- Comment #8 from Ant Bryan <anthonybryan at gmail.com>  2009-01-11 03:23:45 EDT ---
(In reply to comment #7)
> (In reply to comment #6)
> > Do I need to switch to
> > %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from
> > distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
> > 
> > at the beginning of the spec file? It says "sitelib for noarch packages,
> > sitearch for others"
> 
> No, because you are not using %{python_arch} anywhere in the %files section.
> Remove the %{!?python_sitearch:... from the spec, you are not going to need it.

Removed.

> > Why don't I see any output when I run gget from a terminal?
> 
> No idea, you should.

It works now.

> > Even with this change, gget still doesn't run for me.
> 
> What version and arch are you using?

It runs now, my 0.0.4-4 and 0.0.4-5 versions, i386.

> > Ok, done.
> 
> Yeah, but you are using /usr/share/icons/hicolor/*/apps/gget.* which is
> STRICTLY forbidden. Needs to be %{_datadir}/icons/hicolor/*/apps/gget.*

Ok, changed it.

> > I removed "%define epimajor 2.23". Where should I use wildcards?
> 
> You removed the 'define...', but you did not remove %{epimajor} from
> Requires/BuildRequires. IMO you can remove both and then use wildcards in the
> files section (as you already do).

Ok, removed %{epimajor} everywhere.

> A site note on this issue:
> 
> $ rpm -ql gget-epiphany-extension | grep epi
> /usr/lib/epiphany
> /usr/lib/epiphany/2.22
> /usr/lib/epiphany/2.22/extensions
> ...
> 
> As you can see these three directories are already owned by epiphany and there
> should not be duplicate dir ownerships as outlined in
> https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
> So usually we would just own the files, not the dirs with
> %{_libdir}/epiphany/2.22/extensions/py*

I'm using Fedora 10, which has Epiphany 2.24. So I used

%{_libdir}/epiphany/*/extensions/gget*

Is that ok?

> The problem is: If epiphany gets updated from 2.22 to 2.23 the three
> directories will become unowned. 

What do I need to do? Just the rebuilds you mention below?

> BTW: This also means you will need to to a rebuild gget after every major
> version update of epiphany.

That's not a problem for me.

Spec URL: http://pastebin.ca/1305804
SRPM URL: http://www.metalinker.org/mirrors/gget/gget-0.0.4-5.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.