[Bug 479585] Review Request: megaupload-dl - Megaupload automatic downloader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479585


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de




--- Comment #3 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-11 15:13:24 EDT ---
Good:
+ RPMlist is silent on source rpm.
+ Basename of the SPEC file fit the package name.
+ Consistent usage fo rpm macros
+ %doc section is small, so no sepearte doc subpackage is require.
+ Tar Ball match with upstream tar ball:
(md5sum: 8a03cafa72888565f48cf100150c004a)
+ Files sections contains no files or directories which belongs to othe
packages.

Bad:
- Package should contains the BRs to python a python-BeautifulSoup.
- Place remove the argument from the get_python_lib funcstion, so you should
wrote:
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
- Please put 
%{python_sitelib}/megaupload*
into the %files section, so the egg-info file may be includes into your
package.
- Please a 'BuildArch: noarch' on your package, because it's doesn't contains
archtiecture depending contents.
- Con't verfiy License tag of the package.
- Not any source files of the package contains a copyright notice.
- package contains no verbatin copy of the license text.
(I have open a but on the upstream website. Please refer to
http://code.google.com/p/megaupload-dl/issues/detail?id=2)
- Rpmlint complaints on binary rpm:
megaupload-dl.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/megaupload_dl/lib.py 0644
megaupload-dl.noarch: W: spurious-executable-perm
/usr/share/doc/megaupload-dl-0.1.3/megaupload_dl_wget.sh
megaupload-dl.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/megaupload_dl/megaupload_dl.py 0644

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.