[Bug 479723] Review Request: cgit - A fast webinterface for git

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 12 20:01:16 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479723





--- Comment #5 from Todd Zullinger <tmz at pobox.com>  2009-01-12 15:01:13 EDT ---
(In reply to comment #3)
> The other comment I have from a quick look is that the %define at the top for
> the make really probably should just be explicitly in the %build section.

True, it could be.  I had it there to start, but it causes a spurious warning
from rpmlint, which I figured could be easily avoided by defining it outside of
%build and %prep.  Does that cause any harm?  And is it uglier there than the
rpmlint warning might be?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list