[Bug 479732] Review Request: perl-MooseX-Role-Parameterized - parameterized roles
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 13 03:54:34 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479732
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-01-12 22:54:33 EDT ---
- Needs work
+ Ok
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1047503
- rpmlint is silent NOT for SRPM and for RPM.
perl-MooseX-Role-Parameterized.src: W: summary-not-capitalized parameterized
roles
perl-MooseX-Role-Parameterized.noarch: W: summary-not-capitalized parameterized
roles
+ source files match upstream url
2adcf2c7225c34768d80efb018d877ab MooseX-Role-Parameterized-0.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=17, Tests=104, 6 wallclock secs ( 0.06 usr 0.02 sys + 5.19 cusr 0.24
csys = 5.51 CPU)
+ Package perl-MooseX-Role-Parameterized-0.02-1.fc11 =>
Provides:
perl(MooseX::Role::Parameterized) = 0.02
perl(MooseX::Role::Parameterized::Meta::Role::Parameterizable) = 0.02
perl(MooseX::Role::Parameterized::Meta::Role::Parameterized) = 0.02
perl(MooseX::Role::Parameterized::Parameters) = 0.02
perl(MooseX::Role::Parameterized::Tutorial) = 0.02
Requires:
perl(Moose)
perl(Moose::Role)
perl(MooseX::Role::Parameterized::Meta::Role::Parameterizable)
perl(MooseX::Role::Parameterized::Meta::Role::Parameterized)
perl(MooseX::Role::Parameterized::Parameters)
perl(constant)
Suggestion:
1) Summary is not capitalized as reported by rpmlint. Fix that before cvs
import.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list