[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 13 04:52:42 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479669
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-01-12 23:52:41 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1048549
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c0d63d05db01a6da3aebd7cd6f93e520 File-pushd-1.00.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=37, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.19 cusr 0.05
csys = 0.26 CPU)
+ Package perl-File-pushd-1.00-1.fc11=>
Provides: perl(File::pushd) = 1.00
Requires: perl >= 0:5.004 perl(Carp) perl(Cwd) perl(Exporter)
perl(File::Path) perl(File::Spec) perl(File::Temp) perl(overload) perl(strict)
Suggestions:
1) Remove "BuildRequires: perl >= 0:5.004" from spec.
2) remove "Requires: perl(Test::More) >= 0.45" Not needed.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list