[Bug 475897] Review Request: ncmpcpp - Clone of ncmpc with new features and written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475897





--- Comment #3 from Michal Nowak <mnowak at redhat.com>  2009-01-13 06:31:08 EDT ---
(In reply to comment #2)
> Some comment before I do a full review.
> 
> - '-n %{name}-%{version}' is not needed in %setup because this is the default.

Duh... sure.

> - ChangeLog is missing in %doc

...but is also 0lenght, not much use of it. It's GNU build system residuum.

> - I personally like one line per BR ;-)

So do I. From now on.

--

Updated:

Spec URL: http://mnowak.fedorapeople.org/ncmpcpp/ncmpcpp.spec
SRPM URL: http://mnowak.fedorapeople.org/ncmpcpp/ncmpcpp-0.2.5-3.fc10.src.rpm

Tue Jan 13 2009 Michal Nowak <mnowak at redhat.com> 0.2.5-3
- minor SPEC file changes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.