[Bug 464013] Review Request: findbugs-bcel - Byte Code Engineering Library with findbugs extensions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464013





--- Comment #11 from Mary Ellen Foster <mefoster at gmail.com>  2009-01-13 11:45:06 EDT ---
I'm so sorry about the delay in doing this review -- it got sucked into the
Christmas-holiday black hole. I'd say I wouldn't worry about the
duplicate-classes thing until it comes up as an issue.

The suggestions to use %{_java} etc were based on my misunderstanding of some
packaging guidelines and you should be able to just use java/jar/etc. directly.
I'd also recommend adding a link somewhere in the comments to the findbugs
website.

It failed to build for me on F10 i386 mock with the following errors. It looks
like you need to specify "-source 1.5" on the javac line? This is probably
related to gcj/openjdk differences because it built cleanly for me using local
rpmbuild.

33. ERROR in src/java/org/apache/bcel/classfile/ConstantUtf8.java (at line 45)
        private static HashMap<String, ConstantUtf8> cache;
                               ^^^^^^^^^^^^^^^^^^^^
Syntax error, parameterized types are only available if source level is 1.5
----------
34. WARNING in src/java/org/apache/bcel/classfile/ConstantUtf8.java (at line
70)
        cache = new LinkedHashMap<String, ConstantUtf8>(INITIAL_CACHE_CAPACITY,
0.75f, true) {
                   
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The serializable class  does not declare a static final serialVersionUID field
of type long
----------
35. ERROR in src/java/org/apache/bcel/classfile/ConstantUtf8.java (at line 70)
        cache = new LinkedHashMap<String, ConstantUtf8>(INITIAL_CACHE_CAPACITY,
0.75f, true) {
                                  ^^^^^^^^^^^^^^^^^^^^
Syntax error, parameterized types are only available if source level is 1.5
----------
36. ERROR in src/java/org/apache/bcel/classfile/ConstantUtf8.java (at line 78)
        ConstantUtf8 result = cache.get(s);
                              ^^^^^^^^^^^^
Type mismatch: cannot convert from Object to ConstantUtf8
----------
----------
37. ERROR in src/java/org/apache/bcel/generic/ObjectType.java (at line 38)
        private static HashMap<String, ObjectType> cache;
                               ^^^^^^^^^^^^^^^^^^
Syntax error, parameterized types are only available if source level is 1.5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.