[Bug 478640] Review Request: dlfcn - mingw32-dlfcn

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478640


Adel Gadllah <adel.gadllah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |adel.gadllah at gmail.com
               Flag|                            |fedora-review?




--- Comment #4 from Adel Gadllah <adel.gadllah at gmail.com>  2009-01-13 15:03:31 EDT ---
"Fix it with sed in the %prep section: %{__sed} -i 's/\r//' src/somefile --
DONT use dos2unix, that can cause build fail on FC3. "

Well you should stick to the guidelines even if FC3 is long dead.
Pass %{?_smp_mflags} to make unless you have a reason not to do so.

Will do a formal review later this week (limited time).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.