[Bug 225977] Merge Review: ksh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225977





--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2009-01-13 19:21:38 EDT ---
1.) Spec file legibility: No useless comments please.

#ExclusiveArch:  x86_64
#ExcludeArch:  ia64
#Patch0:       ksh-20041225-gcc4.patch
#%patch0 -p1 -b .gcc4
...

2.) If you temporarily disable a patch, please remove it only from %prep, not
the tag itself, so that the patch is bundled with srpm:

# for debugging only:
#Patch100:     ksh-20060124-iffedebug.patch

3.) Use macros. Replace /usr/bin with %{_bindir}

mkdir -p $RPM_BUILD_ROOT{/bin,/usr/bin,%{_mandir}/man1}
/usr//bin/ksh
ln -sf /bin/ksh $RPM_BUILD_ROOT/usr/bin/ksh
...

4.) Use %find_lang for locales

%files
%{_datadir}/locale/*/LC_MESSAGES/*

5.) RPMlint:

ksh.src:28: W: unversioned-explicit-provides ksh93
ksh.src:29: W: unversioned-explicit-obsoletes ksh93

Though it is advisable to version I think it's ok if you leave these as they
are; this had been unversioned for some time already and ksh93 is probably
won't coming back anyways.

ksh.src: W: patch-not-applied Patch4: ksh-20080725-ttou.patch

Either remove the file, or explain why is it disabled.

6.) Upstream the patches

Please submit the patches to usptream & comment on status.
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

7.) Latest upstream release

Latest release seems to be 2008-11-04. Please update.

8.) Avoid absolute symlinks

ln -sf /bin/ksh $RPM_BUILD_ROOT/usr/bin/ksh

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.