[Bug 479667] Review Request: perl-ORLite-Migrate - Extremely light weight SQLite-specific schema migration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479667


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-01-14 05:43:57 EDT ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: devel/x86_64
 [!] Rpmlint output:
source RPM:
perl-ORLite-Migrate.src: E: description-line-too-long SQLite is a light weight
single file SQL database that provides an excellent platform for e
mbedded
perl-ORLite-Migrate.src: E: description-line-too-long storage of structured
data. ORLite is a light weight single class Object-Relational Mapper
(ORM)
perl-ORLite-Migrate.src: E: description-line-too-long system specifically
designed for (and limited to only) work with SQLite. ORLite::Migrate is
 a light
1 packages and 0 specfiles checked; 3 errors, 0 warnings.
binary RPM:
perl-ORLite-Migrate.noarch: E: description-line-too-long SQLite is a light
weight single file SQL database that provides an excellent platform fo
r embedded
perl-ORLite-Migrate.noarch: E: description-line-too-long storage of structured
data. ORLite is a light weight single class Object-Relational Mapp
er (ORM)
perl-ORLite-Migrate.noarch: E: description-line-too-long system specifically
designed for (and limited to only) work with SQLite. ORLite::Migrate
 is a light
1 packages and 0 specfiles checked; 3 errors, 0 warnings.
=> current lines have 92 chars, exceeding the 80 chars limit checked by rpmlint
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging G
uidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(
s) for the package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of package: 010475d7e87a17316db969c4fe9ce71602c0cb6f
ORLite-Migrate-0.01.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build + devel/x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: koji scratch build + devel/x86_64
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass.
 [x] Final provides and requires are sane.
 [x] "make test" passes

================
*** APPROVED *** but before commit please shorten the lines used in
%descriptions to <80 chars
================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.