[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480037





--- Comment #4 from Matthias Clasen <mclasen at redhat.com>  2009-01-14 14:09:19 EDT ---
Formal review:

rpmlint: see above
package name: ok
spec file name: ok
packaging guidelines: 
 - Looks to me like the dbus-glib and PolicyKit requires are redundant, 
   since they are already pulled in by library dependencies
 - should include AUTHORS and NEWS as %doc
license: ok
license field: should be GPLv2+ (note the +), since the source files say "or 
   any later version"
license file: must be included
spec file language: ok
spec file legible: ok
upstream sources: ok
buildable: ok
excludearch: ok
build deps: ok
locale handling: ok
shared libraries: ok
relocatable: not applicable
directory ownership: ok
duplicate files: ok
permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
header files: ok
static libs: ok
pkgconfig files: ok
shared libs: ok
devel package: not applicable
libtool archives: ok
desktop files: not applicable
file ownership: ok
%install: ok
utf8 filenames: ok

summary:
- fix summary/description
- fix license tag
- include license file
- remove redundant requires
- include %doc files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.