[Bug 480050] Review Request: libchamplain - Map view for Clutter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480050


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #2 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-14 15:04:33 EDT ---
Good:
+ Basename of spec file match with package name
+ Package name fits naming guidelines
+ Source tar ball could downloaded with spectool
+ Tar ball in package matches with upstream
(md5sum: fa4a620efa1a1c1036b6701b7d4dafe1)
+ Package contains a valid OSS license on license tag
+ Package contains a verbatin copy of the license text
+ Rpmlinkt ok with source package.
+ Rpm macros are used consitently
+ BUILDROOT will be clean on the beginning of the %install and %clean stanza
+ Package contains ldconfig scriptlet
+ Package contains several subpackages
+ devel subpackage Requires maiin package
+ %doc stanza is small
+ Koji build works fine
+ Rpmlint is quite on binary packages
+ Rpmlint is quite on debugin package
+ Local install works fine
+ Rpmlint is quite on instlled package
+ Local remove of the package works fine
+ files of the packages doesn't belongs to other packages
+ no duplicate files are listed in the %file stanza
+ All listed files are owned by the package
+ %doc stanza is small so we need no doc subpackage
+ Package contains valid %changelog

Bad.
- Local build fails with:
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -o .libs/libchamplain-scan
.libs/libchamplain-scan.o
-pthread -Wl,--export-dynamic  -lgdk-x11-2.0 -lclutter-cairo-0.8
-lclutter-glx-0.8 -lpangocairo-1.0 -lgthread-2.0 -lrt -lgdk_pixbuf_xlib-2.0
-lpango-1.0 -lgdk_pixbuf-2.0 -lcairo
 -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0
../../champlain/.libs/libchamplain-0.2.so  -Wl,--rpath -Wl,/usr/lib64
creating libchamplain-scan
gtk-doc: Running scanner libchamplain-scan
Scan failed:
make[2]: *** [scan-build.stamp] Error 255
make[2]: Leaving directory
`/home/s4504kr/rpmbuild/BUILD/libchamplain-0.2.8/docs/reference'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/s4504kr/rpmbuild/BUILD/libchamplain-0.2.8'
make: *** [all] Error 2

ToDO.

you can wrote

%{_includedir}/%{name}-0.2/

instead of

%dir %{_includedir}/%{name}-0.2
%{_includedir}/%{name}-0.2/champlain

and 

%{_datadir}/champlain/

instead

%dir %{_datadir}/champlain
%{_datadir}/champlain/error.svg

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.