[Bug 479953] Review Request: gtksourceviewmm - C++ wrapper for the gtksourceview widget library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479953


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-14 16:11:46 EDT ---
Good:
+ Base name of the SPEC file metches with package name
+ Package name fits with naming guidelines
+ Package contains most recent release.
+ Tar ball could be downloaded from upstream vis spectool
+ Tar Ball in package matches with upstream
(md5sum: 2306402f31dff1cb9d3d664aa9153c28)
+ License tag contains valid OSS license
+ Package contains verbatin text of the license
+ content of the license tag fits with copyright notes in the source files
+ Rpmlint is ok for source rpm
+ Package contains devel subpackage
+ devel subpackage contains req. to main package
+ %doc stanza is small, so we need no extra doc subpackage
+ Files of the package belongs to the package
+ Files doesn't owned by an other package

Bad:
- Local build fails with:
checking for gm4... no
checking for m4... m4
checking whether m4 is GNU m4... no
checking whether make is GNU Make... yes
checking for x86_64-unknown-linux-gnu-pkg-config... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for GTKSOURCEVIEWMM... configure: error: Package requirements
(gtkmm-2.4 >= 2.4 gtksourceview-2.0 >= 2.2.0) were not met:

No package 'gtksourceview-2.0' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables GTKSOURCEVIEWMM_CFLAGS
and GTKSOURCEVIEWMM_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

- Build on koji fails, Please refer to
http://koji.fedoraproject.org/koji/taskinfo?taskID=1053743
- Group tag should be Development/Libraries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.