[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 15 17:33:12 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476360





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-15 12:33:10 EDT ---
Well, sorry for not pointing out before, however:

- now you defined %gemdocsdir, it is better that you use this macro
  also on %files

- Also you use %{gemdir}/gems/%{gemname}-%{version}/ in %files, while
  %{geminstdir} is also used in %files.

- Now build.log warns about:
-----------------------------------------------------------
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/tlsmail-0.0.1/README.txt
-----------------------------------------------------------

- In %changelog, please use %% instead of single % (i.e. %%doc, for
  example) to aviod macros from being expanded.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list