[Bug 467391] Review Request: mingw32-gdbm - MinGW port of GNU database routines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467391


Tim Lauridsen <tim.lauridsen at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Tim Lauridsen <tim.lauridsen at googlemail.com>  2009-01-16 05:02:55 EDT ---
MUST:
* package must match the upstream source 
cd543862287f55ad66e62cc9d82cc906  gdbm-1.8.0.tar.gz (upstream)
cd543862287f55ad66e62cc9d82cc906  gdbm-1.8.0.tar.gz (srpm)

* package is named appropriately
    mingw32-*
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{?dist} is used
* no license text included in package  
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager, Vendor ,Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* /sbin/ldconfig used in packages containing libraries.
    no native libs
* GUI app, has .desktop file and uses desktop-file-install to install it.
    not a gui app
* header files goes into -devel sub-package.
    no native header files
* *.so goes into -devel sub-package.
    no *.so files
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* The spec file handles locales properly (%find_lang )
    no locales
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* %defattrs present 
* %clean present
* %doc files do not affect runtime
* packages is following the MinGW guidelines
(http://fedoraproject.org/wiki/Packaging/MinGW)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.