[Bug 225612] Merge Review: beagle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225612


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa at redhat.com
               Flag|                            |fedora-review?




--- Comment #1 from Tom "spot" Callaway <tcallawa at redhat.com>  2009-01-16 16:21:57 EDT ---
Okay, here comes rpmlint on the latest in rawhide:

beagle.src: W: strange-permission beagle-thunderbird-update.sh 0775

Probably safe to ignore.

beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-windows
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/BeagleSearch.xml
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/query-mapping.xml
beagle.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/beagled-autostart.desktop
beagle.x86_64: W: non-conffile-in-etc
/etc/beagle/crawl-rules/crawl-applications
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Networking.xml
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/blocate.conf
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-monodoc
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/external-filters.xml.sample
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Daemon.xml
beagle.x86_64: W: non-conffile-in-etc
/etc/beagle/crawl-rules/crawl-documentation
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-executables
beagle.x86_64: W: non-conffile-in-etc
/etc/beagle/config-files/FilesQueryable.xml
beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-manpages

Please mark all of these as %config(noreplace).

beagle.x86_64: E: non-executable-script /usr/lib64/beagle/keygrabber.py 0644

Please fix permissions on that script.

beagle.x86_64: W: non-standard-uid /var/cache/beagle beaglidx
beagle.x86_64: W: non-standard-gid /var/cache/beagle beaglidx
beagle.x86_64: W: non-standard-uid /var/cache/beagle/indexes beaglidx
beagle.x86_64: W: non-standard-gid /var/cache/beagle/indexes beaglidx

Safe to ignore.

beagle.x86_64: W: devel-file-in-non-devel-package /usr/bin/beagle-config
beagle.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/beagle/libbeagleglue.so

beagle.x86_64: E: explicit-lib-dependency libbeagle

Safe to ignore. Odd that it doesn't end up building against libbeagle though.

beagle.x86_64: W: dangerous-command-in-%post rm
beagle.x86_64: W: dangerous-command-in-%preun rm

Safe to ignore.

beagle-devel.x86_64: W: no-documentation
Please mark /usr/lib64/monodoc/sources/beagle-docs.* as %doc.

beagle-devel.x86_64: E: only-non-binary-in-usr-lib

Safe to ignore.

beagle-epiphany.x86_64: W: no-documentation
beagle-epiphany.x86_64: E: only-non-binary-in-usr-lib

Safe to ignore.

beagle-epiphany.x86_64: E: non-executable-script
/usr/lib64/epiphany/2.24/extensions/beagle.py 0644

Please fix permissions on that script.

beagle-evolution.x86_64: W: no-documentation
beagle-evolution.x86_64: E: only-non-binary-in-usr-lib
beagle-firefox.x86_64: W: no-documentation

Safe to ignore.

beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf
beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.xul
beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/indexLink.xul
beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/skin/classic/overlay.css
beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/utils.js
beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/beagle.dtd
beagle-firefox.x86_64: E: script-without-shebang
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.js

Are these really executable scripts? Do they need to be chmod +x?

beagle-firefox.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf

Please fix the end of line encoding here. sed -i 's/\r//' foo

beagle-firefox.x86_64: E: only-non-binary-in-usr-lib
beagle-gnome.x86_64: W: no-documentation

Safe to ignore.

beagle-gnome.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/beagle/libbeagleuiglue.so

You should have a beagle-gnome-devel package for this one.

beagle-thunderbird.x86_64: W: no-documentation
beagle-thunderbird.x86_64: E: only-non-binary-in-usr-lib

Safe to ignore.

*****

Please make the changes that I illustrated from rpmlint, and I'll finish the
review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.