[Bug 477883] Review Request: rubygem-nokogiri - An HTML, XML, SAX, and Reader parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477883





--- Comment #2 from Darryl L. Pierce <dpierce at redhat.com>  2009-01-17 09:20:10 EDT ---
No license file is included in the .gem. Can you ask the upstream to put a
COPYING or LICENSE file into the gem? Not a negative on the review, but a
suggestion for upstream if you could pass it along.

In the spec the file hoe.rb is deleted. Is this package dependant on hoe? You
should add rubygem(hoe) as a dependency.

The install target directory used is the relative path "./" rather than
%{buildroot} macro. Please fix that.

Perhaps I'm misreading, but I don't see where the RPM claims to own
%{geminstdir}, instead it just lists the contents of that directory. Can you
make it more explicit?

For the subpackage ruby-nokogiri, the Requires: does not match the packaging
guidelines: the guideline says the non-gem should require "rubygem(%{name})",
but the spec file has "%{name}". Please fix that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.