[Bug 478767] Review Request: spring - Realtime strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478767


Aurelien Bompard <gauret at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(ianweller at gmail.c
                   |                            |om)




--- Comment #11 from Aurelien Bompard <gauret at free.fr>  2009-01-18 04:15:51 EDT ---
> if this isn't followed, those users who update the spring package
> alone will not see an update to spring-engine.

That's only if the user chooses to explicitly only update the spring package,
and not the spring-engine package, because the latter will also appear in the
available updates (since they come from the same srpm).
So I don't think this will have any impact on updating, meta-packages are only
useful for installing. But I could be wrong !

> - I'm not exactly sure why the rpm-buildroot-usage message is appearing.

That's because I use "RPM_BUILD_ROOT" in %build and not in %install. I have to
do it however, because that's how scons works.

> - If you're not using Patch0, remove it.

Yes, it was needed for the cmake buildsystem, but since I'm using scons...

> - The metapackage needs to be noarch.

I don't think it's possible to have a noarch package and a binary package come
from the same srpm.

> nuke the -engine package and make it just the spring package.

Yeah, I'm leaning in this direction too.

* Sun Jan 18 2009 Aurelien Bompard <abompard at fedoraproject.org> 0.78.1.1-2
- Other changes from the review:
  - remove Cmake-specific patch
  - drop meta-package

http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-0.78.1.1-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.