[Bug 451298] Review Request: pidgin-msn-pecan - Alternative MSN protocol plugin for libpurple

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451298


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #16 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-18 10:05:00 EDT ---
Well, for 0.0.17-1:

* Macros
  - Please use macros consistently for cosmetic issue.
    As you defined %{realname} macro, it is preferred that
    you use this macro also for Name: item.

* License
  - The license tag for this package should be "GPLv2+".

* Make build.log more verbose
  - build.log shows:
--------------------------------------------------------------
    36  + make -j4
    37  [CC] msn.o
    38  [CC] nexus.o
    39  [CC] notification.o
    40  [CC] page.o
    41  [CC] session.o
    42  [CC] switchboard.o
--------------------------------------------------------------
    This is not useful. For example we cannot check from these
    messages if Fedora specific compiler flags (see below)
    are correctly honored.

* Compiler flags / debuginfo rpm
  https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
  - And actually Fedora specific compiler flags are not correctly
    honored currently. You can check what compiler flags should be
    passed by
    $ rpm --eval %optflags

    Currently, on i386:
-------------------------------------------------------------
+ make -j2 V=1
gcc -O2 -Wall  -I. -D PACKAGE='"libmsn-pecan"' -DENABLE_NLS -DHAVE_LIBPURPLE
-DPURPLE_DEBUG -D PLUGIN_NAME='msn-pecan' -DPECAN_CVR -DPECAN_DEBUG_SLP -fPIC
-I/usr/include/libpurple -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I./fix_purple -D
VERSION='"0.0.17"' -MMD -o msn.o -c msn.c
gcc -O2 -Wall  -I. -D PACKAGE='"libmsn-pecan"' -DENABLE_NLS -DHAVE_LIBPURPLE
-DPURPLE_DEBUG -D PLUGIN_NAME='msn-pecan' -DPECAN_CVR -DPECAN_DEBUG_SLP -fPIC
-I/usr/include/libpurple -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I./fix_purple -D
VERSION='"0.0.17"' -MMD -o nexus.o -c nexus.c
-------------------------------------------------------------
    while,
-------------------------------------------------------------
$ rpm --eval %optflags
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables
-------------------------------------------------------------
   - Also, as a result the created debuginfo rpm contains no debugging
     information.

* gettext files
  - It seems that po/ directory contains many gettext .po files.
    Would you explain why you don't compile these files by msgfmt
    (in gettext rpm) and install the created .mo files?

* Test program
  - This tarball contains some files under tests/ directory.
    If some test programs can be executed, add %check section
    and write the programs in %check section.

* Documents
  - Also add the following file(s) to %doc.
------------------------------------------------------------
AUTHORS
COPYING
(TODO)
------------------------------------------------------------

By the way, please change the release number every time
you modify your spec file to avoid confusion.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.