[Bug 478565] Review Request: gupnp-igd - Library to handle UPnP IGD port mapping

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478565


Denis Leroy <denis at poolshark.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |denis at poolshark.org
         AssignedTo|nobody at fedoraproject.org    |denis at poolshark.org
               Flag|                            |fedora-review+




--- Comment #1 from Denis Leroy <denis at poolshark.org>  2009-01-18 16:54:06 EDT ---
* Package name OK
* Source md5sum correct
* License is LGPLv2+
* Package works (able to compile tests and examples)
* Buidls, BR and R are OK
* %files section OK

* rpmlint

  - mixed-use of-spaces-and-tabs : can be ignored
  - unused-direct-shlib-dependency : could use the --as-needed sed trick, but
not a blocker


Warning:
 on Fedora branches <= 10, the devel package will Require gupnp-devel

Package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.