[Bug 479983] Review Request: emacs-mew - Email client for GNU Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479983


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #7 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-19 12:01:51 EDT ---
Good:
+ Basename of the SPEC files matches package name
+ Package name fits naming guildelines for emacs packages
+ Package contains most recent release of the software
+ Could download upstream tar ball with spectool
+ Tar ball in source rpm matches with upstream
(md5sum: 615de2bc3c511f244311d22485306bb9)
+ Provides/Obsoletes of the renaming prcoess seems ok.
  Rpmlint produced some warning, but because the new package doesn't
  suppoer XEmacs, this seems ok for me.
+ Package contains a valid license tag
+ License tag contains BSD as a valid OSS license
+ Package contains verbatin copy of the license text
+ Emacs source files are package in a separate el subpackage
+ el subpackage contains proper Req. to main package
+ Local build works fine
+ Debuginfo package contains source files
+ Buildroot will be cleaned on the beginning of %install and %clean
+ Build on koji works fine.
+ Local install works fine
+ %doc section contains a small amount of data, so we don't need a doc
subpackage
+ All packaged files have proper file permissions
+ All packaged files are owned by the package
+ There are no files which are in conflict with other packages


Bad:
- Rpmlint complaints source package
emacs-mew.src:396: W: macro-in-%changelog post
emacs-mew.src:401: W: macro-in-%changelog description
emacs-mew.src:419: W: macro-in-%changelog post
emacs-mew.src:420: W: macro-in-%changelog postun
emacs-mew.src: E: tag-not-utf8 %changelog
- Rpmlint complaints binary package
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/incm 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/mewest 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/cmew 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/mewcat 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/smew 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/mewencode 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/mewl 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/mewdecode 0555
emacs-mew.x86_64: E: non-standard-executable-perm /usr/bin/mew-pinentry 0555
emacs-mew.x86_64: W: incoherent-version-in-changelog 6.2.3 ['6.2-3.fc10',
'6.2-3']
emacs-mew.x86_64: E: tag-not-utf8 %changelog
emacs-mew.x86_64: W: obsolete-not-provided mew-xemacs
- rpmlint compaints el subpackage
emacs-mew-el.x86_64: W: no-documentation
emacs-mew-el.x86_64: E: tag-not-utf8 %changelog
emacs-mew-el.x86_64: W: obsolete-not-provided mew
TODO:
- Please notify upstream, that eatch source file should contains
a valid copyright notice
- Local uninstall produced the following messages:
install-info: warning: no entries found for `/usr/share/info/mew.info'; nothing
deleted
install-info: warning: no entries found for `/usr/share/info/mew.jis.info';
nothing deleted

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.