[Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478743


Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |loganjerry at gmail.com
         AssignedTo|nobody at fedoraproject.org    |loganjerry at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Jerry James <loganjerry at gmail.com>  2009-01-19 12:09:38 EDT ---
I'll review this.  I tried building it on F-10, and got the following output at
the end of the rpmbuild run:

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib64/libsaga_api.a
   /usr/lib64/saga/libcontrib_a_perego.a
   /usr/lib64/saga/libgeostatistics_grid.a
   /usr/lib64/saga/libgeostatistics_kriging_variogram.a
   /usr/lib64/saga/libgeostatistics_points.a
   /usr/lib64/saga/libgrid_analysis.a
   /usr/lib64/saga/libgrid_calculus.a
   /usr/lib64/saga/libgrid_discretisation.a
   /usr/lib64/saga/libgrid_filter.a
   /usr/lib64/saga/libgrid_gridding.a
   /usr/lib64/saga/libgrid_spline.a
   /usr/lib64/saga/libgrid_tools.a
   /usr/lib64/saga/libgrid_visualisation.a
   /usr/lib64/saga/libio_esri_e00.a
   /usr/lib64/saga/libio_gps.a
   /usr/lib64/saga/libio_grid.a
   /usr/lib64/saga/libio_grid_gdal.a
   /usr/lib64/saga/libio_grid_grib2.a
   /usr/lib64/saga/libio_grid_image.a
   /usr/lib64/saga/libio_shapes.a
   /usr/lib64/saga/libio_shapes_dxf.a
   /usr/lib64/saga/liblectures_introduction.a
   /usr/lib64/saga/libpj_georeference.a
   /usr/lib64/saga/libpj_proj4.a
   /usr/lib64/saga/librecreations_fractals.a
   /usr/lib64/saga/librecreations_games.a
   /usr/lib64/saga/libshapes_grid.a
   /usr/lib64/saga/libshapes_lines.a
   /usr/lib64/saga/libshapes_points.a
   /usr/lib64/saga/libshapes_polygons.a
   /usr/lib64/saga/libshapes_tools.a
   /usr/lib64/saga/libsim_cellular_automata.a
   /usr/lib64/saga/libsim_ecosystems_hugget.a
   /usr/lib64/saga/libsim_fire_spreading.a
   /usr/lib64/saga/libsim_hydrology.a
   /usr/lib64/saga/libta_channels.a
   /usr/lib64/saga/libta_hydrology.a
   /usr/lib64/saga/libta_lighting.a
   /usr/lib64/saga/libta_morphometry.a
   /usr/lib64/saga/libta_preprocessor.a
   /usr/lib64/saga/libta_profiles.a
   /usr/lib64/saga/libtable_calculus.a
   /usr/lib64/saga/libtable_tools.a
   /usr/lib64/saga/libtin_tools.a

Since you built shared libraries, too, you probably don't want to build the
static libraries.  I suggest passing --disable-static to %configure.  I also
see that you are installing the *.la files.  Normally, this should not be done;
see https://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries.  Is
there some reason for installing those files in this case?

I'll do a full review shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.