[Bug 479903] gdesklets plug-in, Cycle through a collection of pictures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479903


David Nalley <david at gnsa.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at gnsa.us
               Flag|                            |needinfo?(bioinfornatics at gm
                   |                            |ail.com)




--- Comment #11 from David Nalley <david at gnsa.us>  2009-01-19 12:11:12 EDT ---
So a few comments:

1. License type per the source is GPLv2+ not GPL+
2. Source0 has two 'http://' in the listing
3. This is a gui application and yet there is no .desktop file see:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop



The package appears to build fine in mock 

rpmlint output below: 
[ke4qqq at nalleyt61 noarch]$ rpmlint gdesklet-slideshow-0.9-1.fc10.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4qqq at nalleyt61 SRPMS]$ rpmlint gdesklet-slideshow-0.9-1.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4qqq at nalleyt61 SPECS]$ rpmlint gdesklet-slideshow.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.


While working on this review I looked for your fas account and don't see one
with your name or your email address as listed in this bug. If you don't have
one, you'll need to get one, and that probably means you need to set this bug
to block the fe-needsponsor bug so that you can be sponsored as a packager.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.