[Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478743





--- Comment #3 from Jerry James <loganjerry at gmail.com>  2009-01-19 14:15:17 EDT ---
It turns out that adding --disable-static isn't enough.  Your attempt to use
the system libtool wasn't quite right.  You need to pass the -f flag to
autoreconf, and throw away the first of your two sed invocations.  That it, the
%build section should contain this:

autoreconf -i -f
sed -i -e 's|SG_T(\"LD_LIBRARY_PATH\")|SG_T(\"%{_libdir}\")|g' \
          src/saga_core/saga_api/module_library.cpp

%configure --enable-unicode --disable-static

make %{?_smp_mflags}

Even then, rpmlint shows that there are still some problems in this package. 
This is what I get:

saga.x86_64: E: standard-dir-owned-by-package /usr/bin
saga.x86_64: E: library-without-ldconfig-postin /usr/lib64/libsaga_api.so.0.0.0
saga.x86_64: E: library-without-ldconfig-postun /usr/lib64/libsaga_api.so.0.0.0
saga.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/saga-2.0.3/AUTHORS
saga.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/saga-2.0.3/NEWS
saga.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/saga-2.0.3/ChangeLog
saga.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/saga-2.0.3/README
saga.x86_64: E: no-ldconfig-symlink /usr/lib64/libsaga_api.so.0.0.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_gtk2u_richtext-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_gtk2u_aui-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_gtk2u_xrc-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_gtk2u_qa-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_gtk2u_html-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_gtk2u_adv-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_baseu_xml-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0
/usr/lib64/libwx_baseu_net-2.8.so.0

Finally, I see in the build output that there are a number of incorrect printf
directives in this program.  They may cause no harm, but it is probably worth
checking whether they will cause any trouble.  Look for warnings of the form:

warning: format '%FLAG' expects type 'TYPE1' but argument N has type 'TYPE2'

Some of those look like they will print integers incorrectly on 64-bit
platforms.

Can you fix all of this and roll a new package so I don't get confused as to
what you have and what I changed?  Thanks.  If you need a hand with any of it,
let me know.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.