[Bug 478470] Review Request: mrpt - The Mobile Robot Programming Toolkit (MRPT)
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jan 21 15:43:45 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478470
--- Comment #17 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2009-01-21 10:43:44 EDT ---
For 0.6.5-0.1:
* Tarball
- For svn repo based tarball, please follow
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
* BuildRequires
- Some reviewers may say that "BuildRequires: tex(latex) tex(dvips)" is
preferred.
(In reply to comment #14)
> btw, if I got it right, a package, say "foo-1.2.3-0.1.20090118svn" MUST have an
> associated tarball
> "foo-1.2.3.tar.gz", without any indication of the snapshot??
Including revision number in tarball name is highly recommeded.
* Dependency for -devel subpackage
- Requires: opencv is not needed.
- For this package "Requires: opencv-devel" does not seem to be needed,
either.
* Compiler flags
- On some parts Fedora specific compiler flags are not honored.
For example:
--------------------------------------------------------------------------
179 /usr/bin/cmake -E cmake_progress_report
/builddir/build/BUILD/mrpt-0.6.5/CMakeFiles
180 [ 1%]
181 Building CXX object
otherlibs/aria-2.5.1/src/CMakeFiles/mrpt-aria.dir/ArAction.o
182 cd /builddir/build/BUILD/mrpt-0.6.5/otherlibs/aria-2.5.1/src &&
/usr/bin/c++ -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__
-Dmrpt_aria_EXPORTS -O2 -fPIC -D_REENTRANT -fno-exceptions -pthread -fPIC
-I/usr/include/opencv -isystem /usr/lib/wx/include/gtk2-unicode-release-2.8
-isystem /usr/include/wx-2.8 -I/builddir/build/BUILD/mrpt-0.6.5/.
-I/builddir/build/BUILD/mrpt-0.6.5/include/mrpt-config/unix
-I/builddir/build/BUILD/mrpt-0.6.5/include
-I/builddir/build/BUILD/mrpt-0.6.5/include/mrpt/otherlibs
-I/builddir/build/BUILD/mrpt-0.6.5/include/mrpt/otherlibs/aria -o
CMakeFiles/mrpt-aria.dir/ArAction.o -c
/builddir/build/BUILD/mrpt-0.6.5/otherlibs/aria-2.5.1/src/ArAction.cpp
--------------------------------------------------------------------------
(I usually check this by seeking for the word "FORTIFY")
* Directory ownership issue
- -doc subpackage should own %{_datadir}/doc/mrpt-doc/ directory.
Also I will wait for your another review request or your pre-review
of other person's review request.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list