[Bug 429486] Review Request: screenlets - A widget system for Compiz-fusion and Beryl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=429486





--- Comment #31 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2009-01-22 09:26:25 EDT ---
This is a more than 6 month pending review.
I will expect Remi to sponsor Patrice. Until then, here is a pre-review:

@leigh scott
I will pick the Patrice's spec file as he's the original submitter of the
package.
Feel free to participate in this review and submit other package if you want to
be sponsored .


screenlet pre-review - started
only a spec review at this time - not package buit.

NEEDWORK - %{!?python_sitelib: and %{!?python_sitearch: are not needed anymore
in recent Fedora version. (since they are already defined) - Please remove at
least the python_sitearch macro which is irrelevant for a noarch package.
In the same way, please remove every lines that are not relevant for a noarch
package (# Remove CFLAGS=, comments from the spec template, etc).
NEEDWORK - A new version has been released : 0.1.2
NEEDWORK - use the Appropriate short name for License ( GPLv2+ )
NEEDWORK - #Source1 have to be remove - unuseful comment
NEEDWORK - Use Applications/Multimedia instead of Applications/System
NEEDWORK - no doc are bundled in the package, please add the relevant ones.
NEEDWORK - If possible , choose to install the svg icon into
/usr/share/icons/hicolor/scalable/apps, then follow
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GTK.2B_icon_cache
NEEDWORK - the package bundle a .desktop file, but the file was not validated
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
NEEDWORK - You need to use the find_lang macro (you may need to tweak it for
both screenlet and screenlet-manager locales)
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.