[Bug 467403] Review Request: mingw32-libgpg-error - MinGW Windows GnuPGP error library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467403





--- Comment #6 from Richard W.M. Jones <rjones at redhat.com>  2009-01-22 13:04:08 EDT ---
(In reply to comment #5)
> Sorry for the delay here: 

Hey no problem, thanks for taking the time to look at this.

> 1. For buildrequires I see in the build.log: 
> 
> checking for msgfmt...
[..]
> Should you add those to BuildRequires?

Yes, they should be.  I have added those in the updated
package.

> 2. Any reason you can't use %{?_smp_mflags} with your make?
> Or does that not work with mingw32 packages?

Also a bug, added ...

> 3. rpmlint of course has a bunch to say... perhaps you could get it 
> to not complain when the package is mingw32-* on a lot of these?

This page summarises rpmlint warnings:
  https://fedoraproject.org/wiki/MinGW/Rpmlint

> Should you be using %find_lang here: 

Yes, we should be, and I have added it.

Spec file:
http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libgpg-error/mingw32-libgpg-error.spec
SRPM file:
http://koji.fedoraproject.org/koji/getfile?taskID=1074597&name=mingw32-libgpg-error-1.6-9.fc11.src.rpm
* Thu Jan 22 2009 Richard W.M. Jones <rjones at redhat.com> - 1.6-9
- Verify that we are still matching current native package.
- Use auto-buildrequires to identify more accurate list of BRs:
    + BR gettext (for /usr/bin/msgfmt etc)
    + BR mingw32-dlfcn
    + BR mingw32-iconv
- Use _smp_mflags.
- Use find_lang.

A koji scratch build is here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1074596

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.