[Bug 455226] Review Request: php-pecl-runkit - PHP Opcode Analyser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455226





--- Comment #6 from Remi Collet <fedora at famillecollet.com>  2009-01-22 13:18:33 EDT ---
> How I should number its versions

0.9-1.1.CVS20080512 seems ok.

> For what and where more I should comment it?

I'd like to see the exact commands use to build the tarball, just above the
%source., p.e. (export greater than checkout) :

# cvs -d :pserver:cvsread at cvs.php.net/repository export -D 2009-01-22
pecl/runkit
# tar cjf runkit-CVS20090122.tar.bz2 -C pecl runkit
%Source0:  %{peclName}-CVS%{CVS}.tar.bz2

Don't use an URL which doesn't exists

I have well understood than patches are for PHP ABI.

Even if this package is unmaintained, please report the bug and post your
patch(es), it will be usefull for everyone, and probably commited (last commit
is only 5 weeks old on runkit.c).

I don't think restarting apache for each extension is a good idea. This should
probably be removed (Have to search about this in the Guidelines).

Please :
- clean release (remove .Hu... and probably not usefull #*Hu comments)
- update to a recent CVS snapshot 
- register the extension (package2.xml is included)
- add PHP ABI check (see PHP Guidelines)
- add upstream bug reference above %patch
- use Fedora macros %pecl_xmldir, %php_extdir, %pecl_install, ...
- clean $Revision and $Log cvs status lines (spec is quite obfuscated)
- clean changelog (mainly % not acceptable)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.