[Bug 475097] Review Request: gimp-fourier-plugin - A fourier transformation plugin for GIMP.

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 23 17:59:13 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475097


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-23 12:59:12 EDT ---
>From the next time please change the release number
every time you modify your spec file.

* Compiler flags
  - From Makefile and from what "man gimptool" says, for
    this package the following is simpler:
---------------------------------------------------------
%build
export CC="gcc %{optflags}"
make %{?_smp_mflags}
---------------------------------------------------------

* rpmlint issue
  - Now "README" file is not in UTF-8 yet. Please change the
    encoding of this file by iconv.

* Directory permission
---------------------------------------------------------
E: non-standard-dir-perm /usr/share/doc/gimp-fourier-plugin-0.3.2 0644
---------------------------------------------------------
  - Umm.. %defattr(0644,root,root,-) does not seem to work, perhaps
    rpm's bug. This should be either %defattr(-,root,root,-) (preferred)
    or %defattr(0644,root,root,0755)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list