[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481531


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de>  2009-01-26 02:08:14 EDT ---
You package does not comply to the FPG.

* Missing (mandatory):
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

* Missing:
BuildRequires: perl(Test::More)

* Missing:
Permission fixing in %install.

I.e. add
%{_fixperms} %{buildroot}/*
or
%{__chmod} -R u+w %{buildroot}/*
at the end of the %install section

* Superfluous:
Requires: perl


* The testsuite works fine when providing the package with correct BR:'s
(Add BuildRequires: perl(Test::More) )


Non-blocking:
I dislike packages shipping testsuites in %doc, because these
a) occasionally introduce bogus deps due to defects in rpm's dependency
generation.
b) offen don't work
c) add package bloat

... however, this is only my personal preference.

BTW: Are you familiar with Fedora's cpanspec tool? This tools eases
significantly helps with getting started on packaging perl-modules for 
Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.