[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-26 05:53:16 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1081910
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream with different url than given in spec.
ca5abd5fec19da9d51e6312f6707c534  DBIx-Safe-1.2.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs Nothing.
+ Package perl-DBIx-Safe-1.2.5-1.fc11 ->
Provides:
 perl(DBIx::Safe) = 1.2.5
Requires:
 perl >= 0:5.008003
 perl(DBI) >= 1.42
 perl(IO::Handle)
 perl(strict)
 perl(utf8)
 perl(warnings)


Suggestions:
1) remove unnecessary BR from spec.
BuildRequires:  perl >= 1:5.6.1
2)Source URL not working. Working URL is
http://search.cpan.org/CPAN/authors/id/T/TU/TURNSTEP/DBIx-Safe-1.2.5.tar.gz
But looks like URL have " ** UNAUTHORIZED RELEASE **" written. Not sure what
that 
means.
3) Good if you add BRs that will remove warnings from build.log
Warning: prerequisite DBD::Pg 1.49 not found.
Warning: prerequisite DBI 1.49 not found.
Warning: prerequisite Test::More 0.61 not found.
Warning: prerequisite Test::Simple 0.3 not found.
4) License is BSD.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.