[Bug 479835] Review Request: log4c - an application message logging library
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 27 05:28:51 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479835
--- Comment #5 from Kevin Fenzi <kevin at tummy.com> 2009-01-27 00:28:50 EDT ---
1. ok. You can always add a comment reminding yourself to add the check when
it's working.
2, 3, 4: All look good.
5. ok. Sounds good.
6. Sounds good.
7. Sadly, thats not going to pass guidelines:
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
I think your choices are:
- Requires: automake
- Split the .m4 file into a subpackage (log4c-automake?) and Requires: automake
there.
- Move the .m4 file over to being a %doc file.
- Don't ship the .m4 file at all.
Thoughts?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list