[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 27 15:20:21 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #27 from Ralf Corsepius <rc040203 at freenet.de>  2009-01-27 10:20:20 EDT ---
(In reply to comment #26)
> (In reply to comment #23)
> > sed -i -e \
> > "s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS} -include /usr/include/errno.h!"
> > src/conf-cc
> 
>   Wait, this changes the whole command in src/conf-cc, I don't think that's
> intended, do you?
This is what is intended. It changes the compiler call to acknowledge the
settings rpm-packaging expects it to acknowledge.

It has the same effect as
make CC=%{__cc} CFLAGS="${RPM_OPT_FLAGS} -include /usr/include/errno.h"
would have with ordinary Makefiles.

Unfortunately DJB's build-system is "special" and doesn't allow overriding
settings from the environment, therefore one has to resort to hardcoding
settings (which is what this sed call does).

> > sed -i -e \
> > "s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS}!" src/conf-ld
> 
>   How/where do you set this RPM_OPT_FLAGS?
RPM_OPT_FLAGS is an rpm internal variable. It contains the CFLAGS all packages
are supposed to compile with.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list