[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471


Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |petersen at redhat.com
               Flag|                            |fedora-review?




--- Comment #38 from Jens Petersen <petersen at redhat.com>  2009-01-27 23:11:02 EDT ---
Thanks.

Koji scratch build is successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1087751

I can sponsor you, Chris, based on a successful completion of this review. :)

You still need to address some earlier comments though:

(In reply to comment #1)
> - 'Source0:' should point to the upstream source location, if possible.
> 
> - About the .desktop file.  The guidelines says that it should be include as
> 'SourceX:' https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
>  See 'desktop-file-install usage' for details about the installation of this
> file.  Get in touch with upstream and ask them to include the .desktop file. 

(In reply to comment #4)
> - URL should be https://fedorahosted.org/securityguide/
> - Source0 should be point to the upstream source location, to the source
> tarball to be more precise.
>   Please refer to https://fedorahosted.org/web/faq, Section 'How can I publish
> archive releases (tgz, zip, etc) for my project?'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.