[Bug 481322] Review Request: emacs-magit - Emacs interface to the most common Git operations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481322





--- Comment #3 from Tom Moertel <tom at moertel.com>  2009-01-28 00:09:51 EDT ---
Jerry, thanks for the quick and helpful review!

I have fixed the problems you identified:

* Updated the License field.

* Added the missing docs.

* Added source-URL comment per guidelines for VCS-pulled source.

* Tweaked BuildRequires.

* Also, I patched the .texi file to include the fdl.texi file,
  which strangely enough *was* included in the upstream source
  but never got included into the magit.texi file.  I submitted
  the patch upstream.

* Finally, thanks for the tip on simplifying the "-n %{name}-el"
  incantations.

The new spec replaces the old:

Spec URL: http://community.moertel.com/rpms/fedora/10/SPECS/emacs-magit.spec
SRPM URL:
http://community.moertel.com/rpms/fedora/10/SRPMS/emacs-magit-0.7-2.20090122git.fc10.src.rpm

Please let me know if you find any other problems or can think of any
meaningful improvements I can make to the package.

Cheers,
Tom

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.