[Bug 481717] Review Request: ugene - genome analysis suite
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jan 28 12:27:02 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481717
--- Comment #3 from Ivan Efremov <iefremov at unipro.ru> 2009-01-28 07:27:01 EDT ---
(In reply to comment #2)
> - Please place the changelog section at the end of the file. It's not wrong
> just unusual.
done
> - Please add the dist tag to Release -> 'Release: 1%{?dist}'
done
> - You don't need to define macros at the beginning of the file. 'Name:' and
> 'Version:' are already macros. But you must use macros in the %files section
> https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros
fixed
> - Please preserve the time stamps, use ' make install DESTDIR=%{buildroot}
> INSTALL="install -p" ' if possible instead of ' make install
> INSTALL_ROOT=%{buildroot} '
Since Makefile is generated by qmake it has some specific features:
1) it uses INSTALL_ROOT instead of DESTDIR
2) it uses INSTALL_FILE, INSTALL_PROGRAM etc. instead of INSTALL
3) these INSTALL_* variables already have '-p' option
so, there is no problem with time stapms
> - This application has a GUI. You need to install the .desktop file.
> https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
desktop file is part of the upstream tarball and is installed during 'make
install'
> - COPYRIGHT and LICENSE must be added as %doc in the %files section. Maybe
> adding the sample files (out of data/samples in the source) is also a good
> idea.
done. Samples are installed into /usr/share/ugene/data during 'make install'
> - There are 'unowned directories' in your %files section.
> https://fedoraproject.org/wiki/Packaging/UnownedDirectories
fixed
New links:
SPEC: http://ugene.unipro.ru/downloads/ugene.spec
SRPM: http://ugene.unipro.ru/downloads/ugene-1.3.2-1.fc9.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list