[Bug 482902] Review Request: gsh - aggregate several remote shells into one

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482902


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-28 15:26:10 EDT ---
Good:
+ Basename of the SPEC files matches with package name
+ BuildRoot tag is ok
+ Could download upstream tar ball with spectool
+ Package contains a License tag
+ License tag contains GPLv2+ as a valid OSS license
+ Package contains a verbatin copy of the license text
+ License in the copyright notes in the source files matches
with specification on the license tag
+ Local build works fine
+ Koji build works fine
+ Package contains no subpackages
+ %doc stanza is small, so we need no separate doc subpackage
+ Build root will be cleaned at the beginning of %clean and %install
+ Package don't contains any scriptlets
+ %changelog is ok. 

Bad:
- Package doesn't fits with the python SPECE templates
- Build complaints duplicate in the %files stanza
- Package tar ball doesn't match with upstream one
Upstream tar ball:
6b925fe21bb84606b47a9a29d1eb88fb  gsh-0.3.tar.gz 
Packaged tar ball:
9b23c16f1265925989e2c1b4f17b04f9  ../SOURCES/gsh-0.3.tar.gz
- Rpmlint compaints binary package:
$ rpmlint gsh-0.3-1.fc10.noarch.rpm
gsh.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/gsh/pity.py 0644
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
- Please remove the gsh.egg-info directory from the sources in the %setup
stanza
to make sure, theat the egg-infos will been built from source

Hints:
* It may be helpful, if you can read and unterstand the python packaging
guideline as
https://fedoraproject.org/wiki/Packaging/Python

This is not a complete review, because the package has some severe errors and
need some love from you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.