[Bug 433678] Review Request: ricci - cluster and systems management agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=433678


Andreas Thienemann <andreas at bawue.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas at bawue.net




--- Comment #13 from Andreas Thienemann <andreas at bawue.net>  2009-01-28 18:28:32 EDT ---
Not to rain on the parade here, but this bug was just mentioned in a discussion
about package quality.
This package review is basically a joke.

Just posting rpmlint results is not enough: The review guidelines clearly
define several items of which only one is mentioned in the review.
A short look at the spec file makes me wonder if anything else then a cursory
rpmlint and mock run was attempted.

While it might be debateable if the .spec file is actually legible but the
missing source url is a clear blocker:

"MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the  Source URL
Guidelines for how to deal with this."

What about the duplicate Summary line?
What about duplicate Requires? What about unneeded Requires?
Why is the main %description tag talking about Conga and a second %description
tag with a name override of "ricci" (identical to the %name tag) talking about
the real program?

What happened to the %files section? Why is the directory
%{_docdir}/ricci-%{version}/ included as regular files instead of being marked
as docs? Why isn't the %doc macro used?

After taking a closer look at the .spec file I have to revise my initial
verdict: This is not only a glaring example of a major failure of our review
process, the entire .spec file is made out of fail.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.