[Bug 482963] Review Request: perl-Network-IPv4Addr - Network-IPv4Addr Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482963


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-28 22:45:15 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090313
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
1c4a9278ada5557a4895ee44b0312888  Network-IPv4Addr-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok
+ Package perl-Network-IPv4Addr-0.05-12.fc11 =>
  Provides: perl(Network::IPv4Addr) = 0.05
  Requires: /usr/bin/perl perl(AutoLoader) perl(Carp) perl(Exporter)
perl(Getopt::Long) perl(Network::IPv4Addr) perl(strict) perl(vars)

Suggestions:
1) Use complete source url as
http://search.cpan.org/CPAN/authors/id/F/FR/FRAJULAC/Network-IPv4Addr-0.05.tar.gz


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.