[Bug 483025] New: Review Request: imms - Adaptive playlist framework tracking and adapting to your listening patterns

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: imms - Adaptive playlist framework tracking and adapting to your listening patterns

https://bugzilla.redhat.com/show_bug.cgi?id=483025

           Summary: Review Request: imms - Adaptive playlist framework
                    tracking and adapting to your listening patterns
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: xjakub at fi.muni.cz
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://mjakubicek.fedorapeople.org/imms/imms.spec
SRPM URL:
http://mjakubicek.fedorapeople.org/imms/imms-3.1.0-0.1.rc6.fc10.src.rpm
Description: IMMS is an adaptive playlist framework that tracks your listening
patterns and dynamically adapts to your taste. Currently we ship only the XMMS
plugin.

Its major features include:

* IMMS is easy to install. It is purely a plugin - no XMMS patch required.
  A very lightweight embedded SQL database is used, so there's no need to setup
  a RDBMS.
* IMMS is easy to use. Song rating is done completely transparently
  to the user. It does not get in your way.
* IMMS does a much better job of shuffling than most players. It keeps track
  of when a song was last played, and makes sure same songs are not repeated
  too often. It is even able to recognise different versions of the same song
  (eg. remixes) and treat them as one song!
* IMMS uses a variety of techniques to figure out which songs should be played
  together, and which should not. It studies your listening habits, as well as
  using acoustic properties of the songs themselves, such as BPM and frequency
  spectrum.
* IMMS is fair. Even unfavoured songs have a (small) chance of being played.

There are some outstanding issues I have to deal with and would appreciate any
help:

1) rpmlint complains about executable-stack:

>rpmlint imms-3.1.0-0.1.rc6.fc10.x86_64.rpm
imms.x86_64: W: executable-stack /usr/bin/immsd
imms.x86_64: W: executable-stack /usr/bin/immstool
imms.x86_64: W: xmms-naming-policy-not-applied
/usr/lib64/xmms/General/libxmmsimms.so

The naming policy is not a problem imho, but I don't know how to get rid of the
executable-stack warning.

2) Licensing issues

The project claims to be GPL, but this license is not specified in source file.
Moreover it includes some (modified) third-party code (see AUTHORS) -- this is
mostly ok (better than own source files, it includes the license) except of:

immscore/xidle.c
model/emd.c
immscore/normal.h

These files and those written by the imms upstream need definitely a license
specified -- I'm going to contact the author and setting FE-LEGAL for now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.