[Bug 482902] Review Request: gsh - aggregate several remote shells into one

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482902





--- Comment #3 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-29 10:44:59 EDT ---
Created an attachment (id=330368)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=330368)
Propose cleanup SPEC file for gsh

Good:
+ Defining python_sitelib macro
+ Packaged tar ball matches with upstream
(md5sum: 6b925fe21bb84606b47a9a29d1eb88fb)
+ Local build works fine
+ Local install works fine
+ Simple call without argument rans without crash
+ Local uninstall works fine
+ Koji build works fine

Bad:
- '-n <name>' flag occurs twice in the %setup macro
- You should remove the gsh.egg-info directory
- %files stanza has a long list of duplicate files entries

I have attached a clenup SPEC file as a proposal for this package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.